Fix LSTNet and DeepSet #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Building the LSTNet on Windows fails for some reason, but I cannot immediately test this myself. Converting to draft for now and will update once the issue is resolved. |
Contributor
|
Thanks, Lars! I will fix the Windows problem. |
Contributor
Author
|
Issue was on the dev branch. Fixed now and merged dev into this. Ready to merge this into dev now. EDIT: @stefanradev93 Some windows issues are still persisting. Can you check this out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title. These networks had issues with their forward passes and serialization. I expanded the test suite slightly and addressed their issues.